fixes the incorrect behavior of appending content using apply_diff with the wrong start_line #3455
Conversation
Fix Pre realworld testing.
…ng proximity boost for matches near preferred lines. Clean up code for better readability and performance.
|
dosubot
bot
added
size:L
xyOz-dev
changed the title
| } | ||
| }) | ||
|
|
||
| it("should prioritize matches close to specified start_line over higher similarity matches further away", async () => { |
There was a problem hiding this comment.
I don't actually think we want it to do this. The intended behavior is to pick the highest similarity match within the buffer range, starting in the center and searching outward from there. Unclear to me if that behavior is not working as expected - do you know?
There was a problem hiding this comment.
I was able to successfully recreate #2657 consistently, ive personally run into the issue a couple times and this does fix the issue, there may be some edge cases that i havent run into but it does seem to work better for me this way
hannesrudolph
moved this from Issue [In Progress]
to PR [Pre Approval Review]
in Roo Code Roadmap
|
@xyOz-dev Did you mean to close this? |
3 participants
Related GitHub Issue
Closes: #2657
Description
fixes the incorrect behavior of appending content using apply_diff with the wrong start_line
Test Procedure
Type of Change
Important
Fixes
applyDiffline number handling and proximity prioritization inmulti-search-replace.ts, adding tests for CSS insertion and line precision.applyDiffinmulti-search-replace.tsby adjusting line number handling and proximity prioritization.fuzzySearch.multi-search-replace.test.tsto verify CSS insertion handling and line number precision.multi-search-replace.test.ts.This description was created by
for a50c6d7. You can customize this summary. It will automatically update as commits are pushed.