Skip to content

fix(task): temporary fix for the ask error #3471

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 13, 2025
Merged

fix(task): temporary fix for the ask error #3471

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2bcc9d8
fix(task): temporary fix for the ask error (#2551)
zxdvd May 11, 2025
8ddb980
Slightly different variation
cte May 13, 2025
29a345c
PR feedback
cte May 13, 2025
25e55aa
Remove some unnecessary instance methods from Task
cte May 13, 2025
c7dd8e3
Fix tests
cte May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/core/task/Task.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -541,7 +541,9 @@ export class Task extends EventEmitter<ClineEvents> {
} else {
// this is a new non-partial message, so add it like normal
const sayTs = Date.now()
this.lastMessageTs = sayTs
if (type !== "checkpoint_saved") {
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot May 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is a temporary workaround to prevent updating lastMessageTs for 'checkpoint_saved' messages, please add a TODO comment referencing the issue and a note that a more robust solution (e.g. tracking lastInteractiveMessageTs) should be implemented in the future.

this.lastMessageTs = sayTs
}
await this.addToClineMessages({ ts: sayTs, type: "say", say: type, text, images, checkpoint })
}
}
Expand Down