-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[CI] Add GitHub Action to auto-close parent issues #3661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
| env: | ||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | ||
| run: | | ||
| # Get the closed issue's number |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Consider adding set -e at the start of the run block to ensure the script exits immediately if a command fails. This would help avoid unpredictable behavior on API errors.
This comment was generated because it violated a code review rule: mrule_OR1S8PRRHcvbdFib.
| repo=$(echo "${{ github.repository }}" | cut -d'/' -f2) | ||
|
|
||
| # Retrieve the issue ID | ||
| issue_id=$(gh api graphql -H "GraphQL-Features: sub_issues" -f query=' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be beneficial to add error handling for the gh api graphql calls. For example, verify that the response contains the expected data before proceeding, to handle API errors gracefully.
This comment was generated because it violated a code review rule: mrule_OR1S8PRRHcvbdFib.
|
Hey @SmartManoj, thank you for the contribution! We've shifted to a issue-first workflow. I'll be closing this issue temporarily but that doesn't mean there's something wrong with this PR. Feel free to reopen this PR if you create an issue for it. I look forward to improving our Github actions with this! |
|
How about a workflow to auto create an issue if it is not there? |
Related GitHub Issue
#2211
Description
Add GitHub Action to auto-close parent issues when all child issues are closed
Test
https://github.com/SmartManoj/Roo-Code/actions/runs/15063558027/job/42343266065
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Important
Adds GitHub Action
close-parent.ymlto auto-close parent issues when all child issues are closed using GraphQL API.close-parent.ymlGitHub Action to auto-close parent issues when all child issues are closed.closedissue events.This description was created by
for 265857a. You can customize this summary. It will automatically update as commits are pushed.