Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 16, 2025

Description

You can't pass temperature, and it looks like we need to update our OpenAI client library to use it.


Important

Support for OpenAI codex-mini model by setting temperature to undefined and adding DEEP_SEEK_DEFAULT_TOP_P constant.

  • Behavior:
    • In openrouter.ts, OpenRouterHandler sets temperature to undefined for models starting with openai/codex.
    • Introduces DEEP_SEEK_DEFAULT_TOP_P in constants.ts and uses it in openrouter.ts for deepseek/deepseek-r1 models.
  • Types:
    • Adds ProviderName type in interface.ts, roo-code.d.ts, and types.ts.
    • Exports providerNames in interface.ts and roo-code.d.ts.
  • Misc:
    • Comments out codex-mini-latest in openAiNativeModels in api.ts.

This description was created by Ellipsis for 14cc21d. You can customize this summary. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented May 16, 2025

⚠️ No Changeset found

Latest commit: fba0de2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels May 16, 2025
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 16, 2025
@hannesrudolph hannesrudolph moved this from New to PR [Pre Approval Review] in Roo Code Roadmap May 20, 2025
@jasonkneen
Copy link

GO GO GO!

@ermaxinc
Copy link

Any news?

@hannesrudolph hannesrudolph moved this from PR [Needs Review] to TEMP in Roo Code Roadmap May 26, 2025
@daniel-lxs daniel-lxs moved this from TEMP to PR [Needs Review] in Roo Code Roadmap May 27, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Preliminary Review] to PR [Needs Review] in Roo Code Roadmap May 28, 2025
@daniel-lxs
Copy link
Member

This looks good to me, it only adds support for OpenRouter as far as I can tell since it's not available in the usual v1 endpoint for native OpenAI.

@mrubens
Copy link
Collaborator

mrubens commented May 28, 2025

I don't think this one works yet

@daniel-lxs daniel-lxs moved this from PR [Needs Review] to PR [Draft / In Progress] in Roo Code Roadmap May 28, 2025
@daniel-lxs daniel-lxs marked this pull request as draft June 3, 2025 23:36
@cte
Copy link
Collaborator Author

cte commented Jun 10, 2025

I don't think the Codex model is going to work for Roo Code; it's been developed for use with the Codex tool and not general programming tasks.

@cte cte closed this Jun 10, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jun 10, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 10, 2025
@cte cte deleted the cte/fix-codex branch June 10, 2025 07:00
@jasonkneen
Copy link

ok -- does work with opencode and others

SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
* migrate toggleWindsurfRules

* changeset

---------

Co-authored-by: Elephant Lumps <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request PR - Draft / In Progress size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

6 participants