Fix: Ensure write_to_file creates empty files when content is empty

[Ruakij]

Early check for partial-block
Small typo
Missing path normalization

Related GitHub Issue

Closes: #3650

Description

This PR fixes a bug where the write_to_file tool would appear to succeed but fail to create files when the content parameter is empty. The tool now properly creates empty files when requested, ensuring consistent behavior regardless of content length.

Key changes:

• Modified the file writing logic to handle empty content correctly
• Enhanced error handling for edge cases
• Refactor file for simplification and reduced code-duplication
• Add Unit-Tests for writeToFileTool

Test Procedure

• Unit-tests
• Ask model to create an empty file

Type of Change

• 🐛 Bug Fix: Non-breaking change that fixes an issue.
• ✨ New Feature: Non-breaking change that adds functionality.
• 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
• ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
• 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
• 📚 Documentation: Updates to documentation files.
• ⚙️ Build/CI: Changes to the build process or CI configuration.
• 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

• Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
• Scope: My changes are focused on the linked issue (one major feature/fix per PR).
• Self-Review: I have performed a thorough self-review of my code.
• Code Quality:
  • My code adheres to the project's style guidelines.
  • There are no new linting errors or warnings (npm run lint).
  • All debug code (e.g., console.log) has been removed.
• Testing:
  • New and/or updated tests have been added to cover my changes.
  • All tests pass locally (npm test).
  • The application builds successfully with my changes.
• Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
• Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
• Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
• Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Documentation Updates

• No documentation updates are required.

Get in Touch

Discord: ruakij

---

Important

Fixes writeToFileTool to handle empty content correctly, adds error handling, refactors for clarity, and introduces comprehensive unit tests.

• Behavior:
  • Fixes writeToFileTool to create files even when content is empty in writeToFileTool.ts.
  • Adds early return for missing path or content in partial blocks.
  • Improves error handling for missing parameters and line count discrepancies.
• Refactoring:
  • Introduces helper functions: validateAccess, checkFileExists, preprocessContent, createMessageProps, and handleDiffViewUpdate in writeToFileTool.ts.
  • Refactors file writing logic for clarity and reduced duplication.
• Testing:
  • Adds writeToFileTool.test.ts with unit tests for parameter validation, access control, file existence, content preprocessing, file operations, partial block handling, user interaction, and error handling.

^{This description was created by for 06d8bbb50beb129a4edca457d34b8bdc3581c46e. You can customize this summary. It will automatically update as commits are pushed.}

[daniel-lxs]

To keep in mind during review: This PR seems to be trying to solve the same issue as PR #3550.

[KJ7LNW]

Pull requests to fix bugs need to be small and targeted, but looking at the differences this is huge and more than necessary to solve the problem.

[daniel-lxs]

Hey @Ruakij, thank you for the contribution, I noticed that this PR introduces a lot of changes that might be outside of the scope of the issue you linked.

Would it make sense to split this PR and create new issues for the other improvements you implemented?

[Ruakij]

I minimized the PR.
Though there is at least another issues i had fixed before, when path is empty or missing or content is missing, no error is returned, because processing will simply stop on line 29.
I have found this through a unit-test. So i feel like this minimize-approach isnt very optimized.. I neither could add the test, nor fix the issue without a new writeup.
Though i do agree adding the refactor to the fix wasnt good.

[daniel-lxs]

@Ruakij
Thank you, It looks great, I will take a look right away

[daniel-lxs]

Looks good to me, the requested changes were properly addressed.

I'm aware that #3550 does pretty much the same thing however that PR currently has requested changes.