Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented May 24, 2025

Related GitHub Issue

Closes: #3924

Description

  • This PR fixes the issues with initialization of a Qdrant collection, it deletes the collection when the vector size changes if a different model is selected.
  • Simplifies the configuration manager by letting the Qdrant class handle vector size changes.
  • Adds unit tests for the Qdrant client to specifically test for this and other scenarios.

Test Procedure

  • Unit tests.
  • Switching embedding providers and making sure the collection is regenerated without issues.

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • [x} There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

N/A

Documentation Updates

  • No documentation updates are required.

Important

Fixes Qdrant collection initialization to handle vector size changes by recreating collections and adds tests for this behavior.

  • Behavior:
    • Fixes Qdrant collection initialization to delete and recreate collections when vector size changes in qdrant-client.ts.
    • Removes requiresClear logic from config-manager.ts and manager.ts.
  • Tests:
    • Adds unit tests in qdrant-client.test.ts to verify collection recreation on vector size change and other scenarios.
  • Misc:
    • Simplifies configuration management by handling vector size changes within the Qdrant class.

This description was created by Ellipsis for 6f87a73. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens merged commit 448dc2b into RooCodeInc:main May 24, 2025
12 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 24, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 24, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
…+ list code definition names tool + access MCP resource tool + load mcp documentation tool + attempt completion tool + browser tool + new task tool (RooCodeInc#3925)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Race condition in collection initalization if ollama is selected as embedding provider

2 participants