feat: enhance OpenRouter model management and fix provider switching issues #3929
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✨ OpenRouter Model Refresh: - Add refresh button with multilingual support (16 languages) - Implement Node.js native https module to bypass Cloudflare blocking - Add auto-initialization of router models on startup - Optimize model fetching with graceful error handling 🔧 Provider Switching Fixes: - Fix useSelectedModel hook with React useMemo for proper dependency management - Resolve Gemini and static providers model display issues - Optimize apiModelId update logic for static providers only - Ensure correct model values when switching between API providers 🌐 Multilingual Support: - Add 'refreshModels' translation key across all 16 supported languages - Maintain consistent UI experience across different locales 🚀 Performance Improvements: - Reduce redundant API calls with smart caching - Improve provider switching responsiveness - Better error handling for network issues
SmartManoj
pushed a commit
to SmartManoj/Raa-Code
that referenced
this pull request
Jun 13, 2025
…s are created using .create() in more contexts (RooCodeInc#3929) * feat(lint): Add custom ESLint rules for protobuf type checking Add two custom ESLint rules to enforce proper usage patterns when creating protobuf objects. Using .create() to build protobufs ensures that the protobuf is type checked when it is created. Protobufs created using object literals are not type checked, which can lead to subtle bugs and type mismatches. The linter rules detect when protobufs are created without using .create() or .fromPartial(). - no-protobuf-object-literals: Enforces the use of `.create()` or `.fromPartial()` methods instead of object literals when creating protobuf types. ``` /Users/sjf/cline/src/shared/proto-conversions/state/chat-settings-conversion.ts 9:9 warning Use ChatSettings.create() or ChatSettings.fromPartial() instead of object literal for protobuf type Found: return { mode: chatSettings.mode === "plan" ? PlanActMode.PLAN : PlanActMode.ACT, preferredLanguage: chatSettings.preferredLanguage, openAiReasoningEffort: chatSettings.openAIReasoningEffort, } Suggestion: ChatSettings.create({ mode: chatSettings.mode === "plan" ? PlanActMode.PLAN : PlanActMode.ACT, preferredLanguage: chatSettings.preferredLanguage, openAiReasoningEffort: chatSettings.openAIReasoningEffort, }) ``` - no-grpc-client-object-literals: Enforces proper protobuf creation for gRPC service client parameters. This needs a separate rule because the type signatures of the ServiceClients methods are too generic to be detected by the previous rule. ``` /Users/sjf/cline/webview-ui/src/components/mcp/configuration/tabs/add-server/AddRemoteServerForm.tsx 41:62 warning Use the appropriate protobuf .create() or .fromPartial() method instead of object literal for gRPC client parameters. Found: McpServiceClient.addRemoteMcpServer({ serverName: serverName.trim(), serverUrl: serverUrl.trim(), }) ``` These rules help maintain code quality by enforcing consistent patterns for working with protocol buffers throughout the codebase, reducing potential runtime errors from improper message construction. * Update test * Add custom eslint rules to new webview-ui config * formatting * stuff * undo protobuf fixes * update rule * update rule * protobuf fixes * rename unused params * formatting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR enhances OpenRouter model management with a refresh button and fixes critical provider switching issues that prevented proper model selection display across different API providers.
Changes Made
✨ OpenRouter Model Refresh Feature
🔧 Provider Switching Fixes
🌐 Internationalization
refreshModelstranslation key across all 16 supported languages🚀 Performance Improvements
Technical Details
Files Modified
src/api/providers/fetchers/openrouter.ts- Native https implementationwebview-ui/src/components/settings/ApiOptions.tsx- Provider switching logicwebview-ui/src/components/settings/providers/OpenRouter.tsx- Refresh button UIwebview-ui/src/components/ui/hooks/useSelectedModel.ts- React dependency fixessrc/core/webview/webviewMessageHandler.ts- Auto-initialization logicwebview-ui/src/i18n/locales/*/settings.json- Multilingual supportBug Fixes
Testing
Breaking Changes
None. All changes are backward compatible.
Related Issues
Fixes provider switching model display issues and enhances OpenRouter usability.
Important
Enhances OpenRouter model management with a refresh button, fixes provider switching issues, and adds multilingual support.
OpenRouter.tsx.httpsmodule inopenrouter.tsto bypass Cloudflare blocking.webviewMessageHandler.ts.useSelectedModelhook inuseSelectedModel.tswith ReactuseMemodependency management.ApiOptions.tsx.apiModelIdupdate logic for static providers.refreshModelstranslation key across 16 languages inlocales/*/settings.json.This description was created by
for 003299e. You can customize this summary. It will automatically update as commits are pushed.