Skip to content

fix: remove await from HMR server check for Windows 10 F5 debugging #3932

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: remove await from HMR server check for Windows 10 F5 debugging #3932

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -575,7 +575,7 @@ export class ClineProvider extends EventEmitter<ClineProviderEvents> implements

// Check if local dev server is running.
try {
await axios.get(`http://${localServerUrl}`)
axios.get(`http://${localServerUrl}`)
Copy link
Contributor

@ellipsis-dev ellipsis-dev bot May 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the await means the try/catch will no longer catch errors from axios.get. If you still intend to handle failures (e.g. to show an error or fallback HTML), consider attaching a .catch() block. Otherwise, removing the try/catch block may be clearer.

} catch (error) {
vscode.window.showErrorMessage(t("common:errors.hmr_not_running"))

Expand Down