Skip to content

bugfix: Update PAGER env for Windows compatibility in Terminal #3986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 28, 2025
Merged

bugfix: Update PAGER env for Windows compatibility in Terminal #3986

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/integrations/terminal/Terminal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,7 +152,7 @@ export class Terminal extends BaseTerminal {

public static getEnv(): Record<string, string> {
const env: Record<string, string> = {
PAGER: "cat",
PAGER: process.platform === "win32" ? "" : "cat",

// VTE must be disabled because it prevents the prompt command from executing
// See https://wiki.gnome.org/Apps/Terminal/VTE
Expand Down
12 changes: 7 additions & 5 deletions src/integrations/terminal/__tests__/TerminalRegistry.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
import { Terminal } from "../Terminal"
import { TerminalRegistry } from "../TerminalRegistry"

const PAGER = process.platform === "win32" ? "" : "cat"

// Mock vscode.window.createTerminal
const mockCreateTerminal = jest.fn()

Expand All @@ -29,15 +31,15 @@ describe("TerminalRegistry", () => {
})

describe("createTerminal", () => {
it("creates terminal with PAGER set to cat", () => {
it("creates terminal with PAGER set appropriately for platform", () => {
TerminalRegistry.createTerminal("/test/path", "vscode")

expect(mockCreateTerminal).toHaveBeenCalledWith({
cwd: "/test/path",
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
},
Expand All @@ -57,7 +59,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
PROMPT_COMMAND: "sleep 0.05",
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
Expand All @@ -79,7 +81,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
ITERM_SHELL_INTEGRATION_INSTALLED: "Yes",
Expand All @@ -100,7 +102,7 @@ describe("TerminalRegistry", () => {
name: "Roo Code",
iconPath: expect.any(Object),
env: {
PAGER: "cat",
PAGER,
VTE_VERSION: "0",
PROMPT_EOL_MARK: "",
POWERLEVEL9K_TERM_SHELL_INTEGRATION: "true",
Expand Down
Loading