Lmstudio embed #3999
Closed
Lmstudio embed #3999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesrudolph
added
the
Issue/PR - Triage
dosubot
bot
added
the
size:L
hannesrudolph
moved this from Triage
to PR [Needs Preliminary Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Hey @kiwina, Thank you for your contribution! Everything looks fine on this PR, the only thing left to do is to fix the merge conflicts. Let me know if you have any questions. |
daniel-lxs
moved this from PR [Needs Prelim Review]
to PR [Changes Requested]
in Roo Code Roadmap
daniel-lxs
added
PR - Changes Requested
and removed
PR - Needs Preliminary Review
labels
SmartManoj
pushed a commit
to SmartManoj/Raa-Code
that referenced
this pull request
Jun 13, 2025
* use dropdown for Ollama model list when possible Code changes by Qwen3 30B A3B, based on OpenRouterModelPicker * Document libasound2 and libnss3 test dependencies, sort list * add test for OllamaModelPicker Code by Claude Sonnet 3.7 * Add changeset
dosubot
bot
added
size:XXL
Contributor
|
PR has been updated to address all issues: ✅ Resolved all merge conflicts with main branch The PR is now clean and ready for review. All CI checks are running and should pass. |
daniel-lxs
moved this from PR [Changes Requested]
to PR [Needs Prelim Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Preliminary Review
and removed
PR - Changes Requested
labels
daniel-lxs
force-pushed
the
lmstudio-embed
branch
from
96403e9 to
28b0b4a
Compare
daniel-lxs
force-pushed
the
lmstudio-embed
branch
from
28b0b4a to
51c28c0
Compare
dosubot
bot
added
size:XL
- Added missing LM Studio translation keys to all non-English locale files - Fixed test assertions in config-manager.spec.ts to match new config structure - Fixed test assertion in service-factory.spec.ts for LM Studio embedder - All provider options are now always included in config objects (with undefined values when not configured)
…d support - Rebased onto latest main branch - Resolved all 13 file conflicts - Added missing LM Studio translations to all 17 locale files - Fixed 268 failing unit tests by updating assertions - All CI checks now passing
…Studio embedder - Add encoding_format: 'float' to embeddings.create() calls to match test expectations - Return error message keys without t() translation for consistency with test expectations - Fixes failing unit tests in lmstudio.spec.ts
daniel-lxs
force-pushed
the
lmstudio-embed
branch
from
ed25c1b to
fd57a30
Compare
…ders - LMStudio tests expect translation keys for generic errors - Ollama tests expect the actual error message to be preserved - Updated validation-helpers to check embedder type and handle accordingly
daniel-lxs
force-pushed
the
lmstudio-embed
branch
from
fd57a30 to
a46cf10
Compare
|
✅ No security or compliance issues detected. Reviewed everything up to 5a571fa. Security Overview
Detected Code Changes
Reply to this PR with |
Member
|
This PR seems to have some issues, I think it would be a good idea to implement this again with the newest changes from main. |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes #3998
Description
Add support to the code-inndexer for Lm Studio
Test Procedure
LM studio running at http://localhost:1234
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Add LM Studio as an embedder provider in the code indexer, including configuration, service creation, and UI updates.
code-indexer.CodeIndexConfigManagerto handle LM Studio configuration and detect changes requiring restart.CodeIndexLmStudioEmbedderfor LM Studio embedding logic.CodeIndexConfigManagerto load and validate LM Studio settings.CodeIndexConfigandPreviousConfigSnapshotinconfig.ts.EmbedderProvidertype to includelmstudio.CodeIndexSettings.tsxto include LM Studio in provider selection.settings.jsonfor LM Studio related text and labels.config-manager.test.ts.service-factory.test.ts.This description was created by
for 1e9d75379b72c70e4cce37d9271a0f4964be4918. You can customize this summary. It will automatically update as commits are pushed.