Skip to content

Conversation

@dtrugman
Copy link
Contributor

@dtrugman dtrugman commented May 27, 2025

Related GitHub Issue

Closes: #4040

Description

Show either the budget or effort control when choosing a model that supports it.
Limited to the Requesty provider.

Test Procedure

Select Requesty as your provider.
Choose any Anthropic reasoning model from any provider (anthropic/vertex/etc) and make sure the reasoning budget slider is visible.
Choose any OpenAI reasoning model and make sure the effort dropdown is visible.

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

No changes to components. The ThinkingBudget component now shows for Requesty. Example:
image

Documentation Updates

Does this PR necessitate updates to user-facing documentation?

  • No documentation updates are required.
  • Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs repository).

Additional Notes

Thank you


Important

Add reasoning budget and effort controls to Requesty provider for Anthropic and OpenAI models.

  • Behavior:
    • Adds reasoning budget and effort controls for Requesty provider in getRequestyModels() in requesty.ts.
    • Shows reasoning budget slider for Anthropic models and effort dropdown for OpenAI models.
  • Classes and Functions:
    • Updates RequestyHandler in requesty.ts to include reasoning_effort and thinking parameters in createMessage() and completePrompt().
    • Modifies RequestyChatCompletionParams to include thinking object with type and budget_tokens.

This description was created by Ellipsis for 6f9b50531855de4ed00cba3359f1adb2f9765cce. You can customize this summary. It will automatically update as commits are pushed.

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For some reason these controls aren't showing up for me when I try to run locally... is it something I'm doing wrong?

Also, we're currently defaulting to coding/claude-4-sonnet - will this logic catch it even though it doesn't have anthropic or openai in the model ID?

@dtrugman
Copy link
Contributor Author

dtrugman commented May 27, 2025

@mrubens, I just realized that I didn't push the PR on my end. It should be working now.

Thanks for pointing out the coding/claude-4-sonnet issue. My bad. Let me change "anthropic" to "claude", that's a better condition.

@dtrugman dtrugman force-pushed the feat/add-thinking-config-to-requesty branch from 6f9b505 to 48c7428 Compare May 27, 2025 14:51
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! There seems to be a bug where you have to change the value of the sliders after enabling reasoning for it to actually kick in, but that's probably not the fault of this PR. @cte any ideas there?

@mrubens mrubens merged commit 4ea7562 into RooCodeInc:main May 27, 2025
10 checks passed
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap May 27, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 27, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
… task lockout bug. (RooCodeInc#4041)

* terminal setting for reusing terminal commands

* language

* changeset

* changeset language

* comment clarity

---------

Co-authored-by: Cline Evaluation <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Add thinking controls to Request provider

2 participants