Skip to content

Fix menu breaking when Roo is moved between primary and secondary sidebars #4045

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 28, 2025
Merged

Fix menu breaking when Roo is moved between primary and secondary sidebars #4045

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
323fce8
Fix menu breaking when Roo is moved between primary and secondary sid…
chrarnoldus May 27, 2025
ceabb08
refactor: improve logging
daniel-lxs May 28, 2025
47dee85
fix: extra bracket
daniel-lxs May 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions src/core/webview/ClineProvider.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,8 @@ export class ClineProvider
this.view = webviewView

// Set panel reference according to webview type
if ("onDidChangeViewState" in webviewView) {
const inTabMode = "onDidChangeViewState" in webviewView
if (inTabMode) {
// Tag page type
setPanel(webviewView, "tab")
} else if ("onDidChangeVisibility" in webviewView) {
Expand Down Expand Up @@ -441,7 +442,12 @@ export class ClineProvider
// This happens when the user closes the view or when the view is closed programmatically
webviewView.onDidDispose(
async () => {
await this.dispose()
if (inTabMode) {
this.log("Disposing ClineProvider because it was in tab mode.")
await this.dispose()
} else {
this.log("NOT disposing ClineProvider because it is in sidebar mode and can be reused.")
}
},
null,
this.disposables,
Expand Down