Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented May 27, 2025

Description

The getModelParams function is the source of truth for generating reasoning effort and extended thinking parameters to pass to the model.


Important

Centralizes model parameter logic in getModelParams for RequestyHandler, MistralHandler, and OpenAiHandler, updating tests to ensure correct parameter usage.

  • Behavior:
    • Centralizes model parameter logic in getModelParams for RequestyHandler, MistralHandler, and OpenAiHandler.
    • Updates getModel() in requesty.ts, mistral.ts, and openai.ts to use getModelParams for maxTokens and temperature.
    • Ensures RequestyHandler includes reasoning_effort and thinking parameters from getModelParams.
  • Tests:
    • Updates requesty.test.ts to verify correct max_tokens and temperature in createMessage and completePrompt.
    • Modifies deepseek.test.ts to ensure DeepSeekHandler initializes with correct API key and model parameters.
  • Misc:
    • Removes redundant logic for setting maxTokens and temperature in mistral.ts and openai.ts.

This description was created by Ellipsis for 344b2e8. You can customize this summary. It will automatically update as commits are pushed.

@cte
Copy link
Collaborator Author

cte commented May 27, 2025

CC @dtrugman

type: string
budget_tokens?: number
}
thinking?: AnthropicReasoningParams
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like Requesty is using the Anthropic format for extending thinking.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label May 27, 2025
stream: true,
stream_options: { include_usage: true },
temperature: undefined,
temperature: 0,
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems we were defaulting to 0 for any provider that made use of getModelParams (including OpenRouter). I'm not 100% sure what the implications of this are for Requesty.

@cte cte merged commit f37e6f6 into main May 27, 2025
10 of 11 checks passed
@cte cte deleted the cte/fix-requesty-reasoning branch May 27, 2025 18:16
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 27, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap May 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants