Improve POSIX shell compatibility in pre-push hook #4053
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesrudolph
added
the
Issue/PR - Triage
dosubot
bot
added
the
size:XS
Contributor
PeterDaveHello
left a comment
PeterDaveHello
left a comment
There was a problem hiding this comment.
Shouldn't I be the git commit author then? The bot can be committer.
Hello Roo Team! We received this contribution on the Kilo side and thought it might be useful to you! This change improves consistency in the pre-push script and improves compatibility with different types of shells. Original pull request: Kilo-Org/kilocode#515
chrarnoldus
force-pushed
the
christiaan/improve-sh-compat
branch
from
1d5ff8e to
1201ed5
Compare
Contributor
Author
|
@PeterDaveHello you're right, I adjusted the author field. Sorry for the inconvenience. |
PeterDaveHello
approved these changes
May 28, 2025
Member
|
LGTM! Since using = instead of == is the POSIX-compliant way for string comparison in single bracket tests, I think we should have this as well. Thanks for the fix! |
daniel-lxs
added
PR - Needs Review
and removed
Issue/PR - Triage
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
cte
approved these changes
May 28, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
SmartManoj
pushed a commit
to SmartManoj/Raa-Code
that referenced
this pull request
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello Roo Team! We received this contribution on the Kilo side (thanks @PeterDaveHello!) and thought it might be useful to you!
Description
This change improves consistency in the pre-push script and improves compatibility with different types of shells.
Original pull request: Kilo-Org/kilocode#515
Type of Change
srcor test files.Important
Fix string comparison operator in
.husky/pre-pushfor better POSIX shell compatibility.==to=in.husky/pre-pushto improve POSIX shell compatibility.This description was created by
for 1d5ff8e21c06b92b2e2000715deaf8fc4c941bdf. You can customize this summary. It will automatically update as commits are pushed.