-
Notifications
You must be signed in to change notification settings - Fork 2.6k
[Condense] Skip condense and show error if the context grows #4061
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
look good, but can we make it grey or yellow text instead of red one ? |
Member
|
LGTM |
Collaborator
I agree! Can you model it after how we show diff errors? Excited for this change in general. |
4ce225e to
221e32d
Compare
7693875 to
5e975aa
Compare
mrubens
approved these changes
May 28, 2025
SmartManoj
pushed a commit
to SmartManoj/Raa-Code
that referenced
this pull request
Jun 13, 2025
The extension doesn't like it when the workspace/workspace config is undefined. Fix the warning about the name in package.json. Change some logging in the gRPC server.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bug
Something isn't working
enhancement
New feature or request
lgtm
This PR has been approved by a maintainer
PR - Changes Requested
size:L
This PR changes 100-499 lines, ignoring generated files.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #3911
Description
Sometimes the context grows rather than shrinking during a context condense. This is an expected edge case under the current implementation: the condense operation preserves the last 3 messages as-is, and tries to summarize the conversation before that point using an LLM call. If the last 3 messages are quite large, and the previous messages are small (or maybe you summarized recently), then you may have reached the threshold, but there's not much that can be done to reduce the context size through summarization while preserving the last 3 messages.
In these cases it's probably best to skip the summary and show the user an error rather than "condensing" the context to a larger size.
Test Procedure
Tried manual and automatic context condenses and observed the error
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos