-
Notifications
You must be signed in to change notification settings - Fork 2.6k
@directory not respecting .rooIgnore Fix #4075
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
@directory not respecting .rooIgnore Fix #4075
Conversation
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
|
LGTM, solves the issue with mentions where ignored files are included regardless of the settings on |
|
Does this still let you directly @-mention rooignored files if you want to manually add them to the context? |
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It seems like this hides the content of ignored files
Related GitHub Issue
Closes: #3598
Description
Fixed @Directory attachments to respect .rooignore files by integrating RooIgnoreController into the mentions processing pipeline
Test Procedure
See linked issue.
Type of Change
Additional Notes
Will be creating a pr to docs shortly
Important
Fixes
@directorymentions to respect.rooignorefiles by integratingRooIgnoreControllerinto the mentions processing pipeline.@directorymentions now respect.rooignorefiles by integratingRooIgnoreControllerinto the mentions processing pipeline inindex.ts.rooIgnoreControllerandshowRooIgnoredFilesparameters toparseMentions()andgetFileOrFolderContent()inindex.ts.processUserContentMentions()inprocessUserContentMentions.tsto handlerooIgnoreControllerandshowRooIgnoredFiles.Taskclass inTask.tsto passrooIgnoreControllerandshowRooIgnoredFilestoprocessUserContentMentions().showRooIgnoredFilesis true.This description was created by
for 4885782. You can customize this summary. It will automatically update as commits are pushed.