Skip to content

Conversation

@canrobins13
Copy link
Contributor

@canrobins13 canrobins13 commented May 28, 2025

Description

Moves the context condensing settings out of experimental and to the Context settings tab.
Also enables autoCondenseContext by default.

Test Procedure

  • Changed the settings around
  • Ensured they persisted and worked

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Screenshot 2025-05-28 at 4 10 16 PM

Documentation Updates

  • No documentation updates are required.
  • Yes, documentation updates are required.

Documentation for context condensing settings should be moved out of experimental and to the appropriate section.


Important

Moves autoCondenseContext from experimental to main context settings, enabling it by default, and updates related UI components and tests.

  • Behavior:
    • Moves autoCondenseContext from experimental to context settings and enables it by default.
    • Updates ClineProvider and Task to handle autoCondenseContext as a main setting.
  • UI Components:
    • Updates ContextManagementSettings.tsx to include autoCondenseContext settings.
    • Removes autoCondenseContext from ExperimentalSettings.tsx.
  • Tests:
    • Adds tests for autoCondenseContext default behavior in ClineProvider.test.ts.
    • Updates ContextManagementSettings.test.tsx to test new settings behavior.
  • Misc:
    • Removes autoCondenseContext from experimental settings in experiment.ts and experiments.test.ts.

This description was created by Ellipsis for bbd1d9a. You can customize this summary. It will automatically update as commits are pushed.

@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap May 28, 2025
@canrobins13 canrobins13 marked this pull request as ready for review May 28, 2025 23:17
@canrobins13 canrobins13 requested review from cte and mrubens as code owners May 28, 2025 23:17
@dosubot dosubot bot added size:XXL This PR changes 1000+ lines, ignoring generated files. documentation Improvements or additions to documentation UI/UX UI/UX related or focused labels May 28, 2025
Comment on lines 340 to 344
"condensingApiConfiguration": {
"label": "API Configuration for Context Condensing",
"description": "Select which API configuration to use for context condensing operations. Leave unselected to use the current active configuration.",
"useCurrentConfig": "Default"
},
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch, will audit these

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh interesting, looks like the issue predates the PR. Will update here anyway

Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some of the translations look wrong, but LGTM otherwise

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 28, 2025
@canrobins13 canrobins13 merged commit 4804e3b into main May 29, 2025
10 checks passed
@canrobins13 canrobins13 deleted the canyon/condense-settings branch May 29, 2025 00:05
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 29, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap May 29, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
* protobuf executeQuickWin

* whitespaces

---------

Co-authored-by: Andrei Eternal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation lgtm This PR has been approved by a maintainer PR - Draft / In Progress size:XXL This PR changes 1000+ lines, ignoring generated files. UI/UX UI/UX related or focused

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants