Skip to content

Conversation

@pugazhendhi-m
Copy link
Contributor

@pugazhendhi-m pugazhendhi-m commented May 30, 2025

Related GitHub Issue

Closes: #4137

Description

This PR improves how we handle cache breakpoints for different models by using the supportsPromptCache flag from model info to determine if cache breakpoints should be added.

Test Procedure

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

Documentation Updates

Additional Notes

Get in Touch


Important

Refactor UnboundHandler in unbound.ts to use model info for selecting cache breakpoint logic, adding support for Gemini and Anthropic models.

  • Behavior:
    • Refactor createMessage in unbound.ts to use model info for cache breakpoints.
    • Calls addGeminiCacheBreakpoints for models starting with google/.
    • Calls addAnthropicCacheBreakpoints for models starting with anthropic/.
  • Imports:
    • Add import for addGeminiCacheBreakpoints from caching/gemini.
    • Rename addCacheBreakpoints to addAnthropicCacheBreakpoints from caching/anthropic.

This description was created by Ellipsis for b7c6551. You can customize this summary. It will automatically update as commits are pushed.

@pugazhendhi-m pugazhendhi-m requested review from cte and mrubens as code owners May 30, 2025 05:52
@dosubot dosubot bot added the size:S This PR changes 10-29 lines, ignoring generated files. label May 30, 2025
@vercel
Copy link

vercel bot commented May 30, 2025

Someone is attempting to deploy a commit to the Roo Code Team on Vercel.

A member of the Team first needs to authorize it.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2025
@cte cte merged commit 7ee90f9 into RooCodeInc:main May 30, 2025
16 of 17 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 30, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap May 30, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants