Pass headers to SSE (fixes #2705) #4148
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
Closes: #2705
Description
Fixes the issue where headers aren't correctly passed through SSE with an approach similar to modelcontextprotocol/typescript-sdk#436 (comment)
Test Procedure
I set up a SSE server locally following https://glama.ai/mcp/servers/@anisirji/mcp-server-remote-setup-with-jwt-auth and confirmed that this change sent the header through correctly with config like this:
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Documentation Updates
Headers are already documented - this just makes them work: https://docs.roocode.com/features/mcp/using-mcp-in-roo#understanding-transport-types
Important
Fixes header passing in SSE connections in
McpHub.tsby modifying thefetchfunction to include headers.McpHub.tsby modifying thefetchfunction to include headers fromconfigInjected.nine-windows-read.mdto document the patch.This description was created by
for 5092a3f. You can customize this summary. It will automatically update as commits are pushed.