Skip to content

Conversation

@canrobins13
Copy link
Contributor

@canrobins13 canrobins13 commented May 30, 2025

Related GitHub Issue

Closes: #4147

Description

Fixes a bug with condensing where AWS Bedrock requires the first message to be a user message:

A conversation must start with a user message. Try again with a conversation that starts with a user message.

Test Procedure

  • Reproduced the bug by condensing and sending an additional message with Bedrock
  • Confirmed the fix worked for this case

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots

Screenshot 2025-05-30 at 3 18 33 PM


Important

Fixes bug in getMessagesSinceLastSummary() to prepend a user message for AWS Bedrock compatibility.

  • Behavior:
    • Fixes bug in getMessagesSinceLastSummary() in index.ts where AWS Bedrock requires the first message to be a user message by prepending a user message.
  • Tests:
    • Updates index.test.ts to test the new behavior of getMessagesSinceLastSummary() with prepended user message.
  • Misc:
    • Adds changeset little-news-warn.md documenting the fix as a major update.

This description was created by Ellipsis for 49f1f7e. You can customize this summary. It will automatically update as commits are pushed.

@canrobins13 canrobins13 marked this pull request as ready for review May 30, 2025 20:00
@canrobins13 canrobins13 requested review from cte and mrubens as code owners May 30, 2025 20:00
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. bug Something isn't working labels May 30, 2025
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels May 30, 2025
@canrobins13 canrobins13 requested a review from mrubens May 30, 2025 20:25
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 30, 2025
@mrubens mrubens merged commit da63d1e into main May 30, 2025
11 checks passed
@mrubens mrubens deleted the canyon/bedrock-condense branch May 30, 2025 21:25
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap May 30, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap May 30, 2025
SmartManoj pushed a commit to SmartManoj/Raa-Code that referenced this pull request Jun 16, 2025
…CodeInc#4150)

* base

* grpc

* grpc

* base 3

* settings stuff

* changeset

* nit

* format

* smol
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

[Context Condensing] A conversation must start with a user message.

3 participants