Skip to content

fix(RooTips): Clear setTimeout in useEffect cleanup to prevent state updates on unmounted components #4235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 4, 2025
Merged

fix(RooTips): Clear setTimeout in useEffect cleanup to prevent state updates on unmounted components #4235

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions webview-ui/src/components/welcome/RooTips.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,15 +32,21 @@ const RooTips = ({ cycle = false }: RooTipsProps) => {
useEffect(() => {
if (!cycle) return

let timeoutId: NodeJS.Timeout | undefined = undefined
const intervalId = setInterval(() => {
setIsFading(true) // Start fade out
setTimeout(() => {
timeoutId = setTimeout(() => {
setCurrentTipIndex((prevIndex) => (prevIndex + 1) % tips.length)
setIsFading(false) // Start fade in
}, 1000) // Fade duration
}, 11000) // 10s display + 1s fade

return () => clearInterval(intervalId) // Cleanup on unmount
return () => {
clearInterval(intervalId)
if (timeoutId) {
clearTimeout(timeoutId)
}
}
}, [cycle])

const currentTip = tips[currentTipIndex]
Expand Down
Loading