Skip to content

fix: SSE MCP Invocation #4251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 2, 2025
Merged

fix: SSE MCP Invocation #4251

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
efc3649
only apply transport.start for stdio
taylorwilsdon Jun 2, 2025
8dd4442
instructions
taylorwilsdon Jun 2, 2025
6ab30b2
formatting
taylorwilsdon Jun 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 13 additions & 4 deletions src/services/mcp/McpHub.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -598,13 +598,23 @@ export class McpHub {
}
await this.notifyWebviewOfServerChanges()
}

transport.onclose = async () => {
const connection = this.findConnection(name, source)
if (connection) {
connection.server.status = "disconnected"
}
await this.notifyWebviewOfServerChanges()
}
} else {
// Correctly placed "unsupported type" else block
// Should not happen if validateServerConfig is correct
throw new Error(`Unsupported MCP server type: ${(configInjected as any).type}`)
}
// transport.start assignment moved after all type-specific initializations
transport.start = async () => {} // No-op now, .connect() won't fail

// Only override transport.start for stdio transports that have already been started
if (configInjected.type === "stdio") {
transport.start = async () => {}
}

const connection: McpConnection = {
server: {
Expand All @@ -625,7 +635,6 @@ export class McpHub {
await client.connect(transport)
connection.server.status = "connected"
connection.server.error = ""
connection.server.instructions = client.getInstructions()

// Initial fetch of tools and resources
connection.server.tools = await this.fetchToolsList(name, source)
Expand Down