Skip to content

fix(modes): prevent missing role definition when selecting default mode #4286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix(modes): prevent missing role definition when selecting default mode #4286

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions src/shared/modes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -171,17 +171,14 @@ export function findModeBySlug(slug: string, modes: readonly ModeConfig[] | unde
* If neither is found, the default mode is used.
*/
export function getModeSelection(mode: string, promptComponent?: PromptComponent, customModes?: ModeConfig[]) {
const customMode = findModeBySlug(mode, customModes)
const builtInMode = findModeBySlug(mode, modes)

const modeToUse = customMode || promptComponent || builtInMode

const roleDefinition = modeToUse?.roleDefinition || ""
const baseInstructions = modeToUse?.customInstructions || ""
const modeToUse =
findModeBySlug(mode, customModes) ||
(promptComponent?.roleDefinition ? promptComponent : undefined) ||
findModeBySlug(mode, modes)

return {
roleDefinition,
baseInstructions,
roleDefinition: modeToUse?.roleDefinition || "",
baseInstructions: modeToUse?.customInstructions || "",
}
}

Expand Down