Skip to content

Conversation

@KJ7LNW
Copy link
Contributor

@KJ7LNW KJ7LNW commented Jun 3, 2025

Context

Add clear guidelines for executing commands in specific workspaces within the monorepo structure.

Implementation

This PR adds a new section to .roo/rules/monorepo.md that explicitly instructs models to:

  • Always use the <cwd>workspace/directory</cwd> parameter when executing commands in specific workspaces
  • Understand the importance of running commands in the correct workspace context

This documentation will help prevent errors in package management, test execution, and build processes by ensuring commands are run in the correct context.

@cte Please review these workspace command execution guidelines to ensure they align with best practices for the monorepo.

Fixes: #4298


Important

Adds guidelines in .roo/rules/monorepo.md for executing commands in specific workspaces using <cwd>workspace/directory</cwd> to ensure correct context and prevent errors.

  • Documentation:
    • Adds guidelines to .roo/rules/monorepo.md for executing commands in specific workspaces using <cwd>workspace/directory</cwd>.
    • Emphasizes correct workspace context to prevent errors in package management, test execution, and build processes.
  • Command Execution:
    • Instructs to run pnpm add <package> in <cwd>workspace/directory</cwd> for dependency installation.
    • Advises against running pnpm in root.
  • Testing:
    • Specifies using <cwd>workspace/directory</cwd> for running test commands.
    • Details test file conventions and handling of .spec.ts and .test.ts files.

This description was created by Ellipsis for 7d1edb2. You can customize this summary. It will automatically update as commits are pushed.

Eric Wheeler added 2 commits June 3, 2025 15:07
Add comprehensive documentation for monorepo structure and workflows:
- Workspace organization and primary development areas
- Package dependency management with pnpm
- Turborepo configuration guidelines
- Test execution strategies for both vitest and jest
- Migration path from deprecated test formats to modern ones

Fixes: #4295
Signed-off-by: Eric Wheeler <[email protected]>
Add a new section to monorepo documentation that clarifies how to execute
commands in specific workspaces using the cwd parameter.

This helps models understand the importance of specifying the correct
workspace context when running commands in the monorepo structure.

Fixes: #4298
Signed-off-by: Eric Wheeler <[email protected]>
@KJ7LNW KJ7LNW requested review from cte and mrubens as code owners June 3, 2025 22:40
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. documentation Improvements or additions to documentation labels Jun 3, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 3, 2025
@daniel-lxs
Copy link
Member

daniel-lxs commented Jun 4, 2025

Hey @KJ7LNW, Thank you for your contribution!
I noticed this PR just adds a single line to the rule, but it's showing that you modified the whole file.

Can you solve the conflicts for clarity?

@daniel-lxs daniel-lxs moved this from Triage to PR [Changes Requested] in Roo Code Roadmap Jun 4, 2025
@daniel-lxs daniel-lxs added PR - Changes Requested and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 4, 2025
@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Jun 5, 2025
@KJ7LNW
Copy link
Contributor Author

KJ7LNW commented Jun 5, 2025

Hey @KJ7LNW, Thank you for your contribution! I noticed this PR just adds a single line to the rule, but it's showing that you modified the whole file.

Can you solve the conflicts for clarity?

that was a strange merge conflict but it should be fixed in a moment

@daniel-lxs
Copy link
Member

Seems to be already added by #4296

@daniel-lxs daniel-lxs closed this Jun 16, 2025
@github-project-automation github-project-automation bot moved this from PR [Changes Requested] to Done in Roo Code Roadmap Jun 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 16, 2025
@KJ7LNW
Copy link
Contributor Author

KJ7LNW commented Jun 16, 2025

Seems to be already added by #4296

Actually this PR is in addition to that one.

@KJ7LNW KJ7LNW reopened this Jun 16, 2025
@KJ7LNW KJ7LNW requested a review from jr as a code owner June 16, 2025 21:40
@github-project-automation github-project-automation bot moved this from Done to New in Roo Code Roadmap Jun 16, 2025
@github-project-automation github-project-automation bot moved this from Done to Triage in Roo Code Roadmap Jun 16, 2025
@KJ7LNW
Copy link
Contributor Author

KJ7LNW commented Jun 16, 2025

@cte I do not see this monorepo.md file in the main branch: https://github.com/RooCodeInc/Roo-Code/tree/main/.roo/rules

did you delete it?

@daniel-lxs
Copy link
Member

Would it be better to make the rule more general to just have it once?
image

@cte
Copy link
Collaborator

cte commented Jun 16, 2025

@cte I do not see this monorepo.md file in the main branch: main/.roo/rules

did you delete it?

#4549

@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jun 16, 2025
@hannesrudolph hannesrudolph added Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. and removed PR - Changes Requested labels Jun 16, 2025
@KJ7LNW
Copy link
Contributor Author

KJ7LNW commented Jun 16, 2025

ok, re-closing this PR. thanks.

@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 16, 2025
@daniel-lxs
Copy link
Member

ok, re-closing this PR. thanks.

Closing.

@daniel-lxs daniel-lxs closed this Jun 16, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jun 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation PR - Draft / In Progress size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Models need clear workspace command execution guidelines

4 participants