Fix #4113: Move relPath & newContent checks in writeToFileTool earlie…

[Ruakij]

Related GitHub Issue

Closes: #4113

Description

Fix tool writeToFile with missing or empty path or missing content.
Checks earlier right after waiting for path & content parameters to be populated, so when block is non-partial, they immediately check instead of later.
This is required as alot of code after requires both to be valid.

Additional unit tests are added to cover these scenarios.

Future work should probably separate partial from non-partial-block logic and modularize the big function for reduced code-complexity.

Test Procedure

• Run Tests
• Try tool-calling writeToFile with missing or empty path/content parameters (see screenshot)

Type of Change

• 🐛 Bug Fix: Non-breaking change that fixes an issue.
• ✨ New Feature
• 💥 Breaking Change
• ♻️ Refactor
• 💅 Style
• 📚 Documentation
• ⚙️ Build/CI
• 🧹 Chore

Pre-Submission Checklist

• Issue Linked
• Scope
• Self-Review
• Code Quality
  • My code adheres to the project's style guidelines.
  • There are no new linting errors or warnings (npm run lint).
  • All debug code (e.g., console.log) has been removed.
• Testing
  • New and/or updated tests have been added to cover my changes.
  • All tests pass locally (npm test).
  • The application builds successfully with my changes.
• Branch Hygiene
• Documentation Impact
• Changeset
• Contribution Guidelines

Screenshots / Videos

Documentation Updates

• No documentation updates are required.

Additional Notes

N/A

Get in Touch

Discord: ruakij

---

Important

Moves parameter validation earlier in writeToFileTool to handle missing or empty path and content immediately, with new tests added.

• Behavior:
  • Moves relPath and newContent checks earlier in writeToFileTool to immediately handle missing or empty parameters.
  • Ensures writeToFileTool returns early if path or content is missing or empty, preventing further processing.
• Testing:
  • Adds unit tests in writeToFileTool.test.ts to verify behavior when path or content is missing or empty.
• Misc:
  • Suggests future refactoring to separate partial and non-partial logic for reduced complexity.

^{This description was created by for 37fb18d. You can customize this summary. It will automatically update as commits are pushed.}

[daniel-lxs]

@Ruakij
Thank you for the fix!

LGTM