Enabling unit tests for CI #44
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
❌ Changes requested. Reviewed everything up to 0e2f0a0 in 32 seconds
More details
- Looked at
27lines of code in1files - Skipped
0files when reviewing. - Skipped posting
1drafted comments based on config settings.
1. .github/workflows/code-qa.yml:25
- Draft comment:
The PR description is missing some required details. Please ensure it includes: - A comprehensive description of what is being changed and why.
- How the changes have been tested.
- Any related tickets/issues.
- Information on visual/UI changes, if any, with before & after screenshots.
This is from our Development Standards: https://www.notion.so/Development-Standards-59febcf8ead647fd9c2ec3f60c22f3df?pvs=4#11869ad2d58180429648e12f7977d646
- Reason this comment was not posted:
Comment did not seem useful.
Workflow ID: wflow_b5QeVQBW7fQrrqcp
Want Ellipsis to fix these issues? Tag @ellipsis-dev in a comment. You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.
a8trejo
approved these changes
Dec 7, 2024
|
|
||
| - name: Compile TypeScript | ||
| run: npm run compile | ||
|
|
Contributor
There was a problem hiding this comment.
On line 11 I would rename code-qa to compile, since all the jobs in this workflow, including unit-test are part of code quality assurance
roomote
pushed a commit
that referenced
this pull request
Jul 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change currently triggers the core Cline unit tests. Note: the webview-ui tests currently appear to have some unrelated issues. Will look into those separately.
Important
Add
unit-testjob to GitHub Actions workflow to run Jest unit tests in CI.unit-testjob to.github/workflows/code-qa.ymlto run unit tests using Jest.This description was created by
for 0e2f0a0. It will automatically update as commits are pushed.