-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Improve the evals "run status" section #4400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| "use server" | ||
|
|
||
| import { redisClient } from "@/lib/server/redis" | ||
|
|
||
| export const getHeartbeat = async (runId: number) => { | ||
| const redis = await redisClient() | ||
| return redis.get(`heartbeat:${runId}`) | ||
| } |
2 changes: 1 addition & 1 deletion
2
apps/web-evals/src/lib/server/runners.ts → apps/web-evals/src/actions/runners.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,55 @@ | ||
| "use client" | ||
|
|
||
| import type { RunStatus as _RunStatus } from "@/hooks/use-run-status" | ||
| import { cn } from "@/lib/utils" | ||
|
|
||
| export const RunStatus = ({ runStatus: { sseStatus, heartbeat, runners = [] } }: { runStatus: _RunStatus }) => ( | ||
| <div> | ||
| <div className="flex items-center gap-2"> | ||
| <div className="flex items-center gap-2"> | ||
| <div>Task Stream:</div> | ||
| <div className="font-mono text-sm text-muted-foreground">{sseStatus}</div> | ||
| </div> | ||
| <div className="relative"> | ||
| <div | ||
| className={cn("absolute size-2.5 rounded-full opacity-50 animate-ping", { | ||
| "bg-green-500": sseStatus === "connected", | ||
| "bg-amber-500": sseStatus === "waiting", | ||
| "bg-rose-500": sseStatus === "error", | ||
| })} | ||
| /> | ||
| <div | ||
| className={cn("size-2.5 rounded-full", { | ||
| "bg-green-500": sseStatus === "connected", | ||
| "bg-amber-500": sseStatus === "waiting", | ||
| "bg-rose-500": sseStatus === "error", | ||
| })} | ||
| /> | ||
| </div> | ||
| </div> | ||
| <div className="flex items-center gap-2"> | ||
| <div className="flex items-center gap-2"> | ||
| <div>Task Controller:</div> | ||
| <div className="font-mono text-sm text-muted-foreground">{heartbeat ?? "dead"}</div> | ||
| </div> | ||
| <div className="relative"> | ||
| <div | ||
| className={cn("absolute size-2.5 rounded-full opacity-50 animate-ping", { | ||
| "bg-green-500": !!heartbeat, | ||
| "bg-rose-500": !heartbeat, | ||
| })} | ||
| /> | ||
| <div | ||
| className={cn("size-2.5 rounded-full", { | ||
| "bg-green-500": !!heartbeat, | ||
| "bg-rose-500": !heartbeat, | ||
| })} | ||
| /> | ||
| </div> | ||
| </div> | ||
| <div className="flex items-center gap-2"> | ||
| <div>Task Runners:</div> | ||
| {runners.length > 0 && <div className="font-mono text-sm text-muted-foreground">{runners?.join(", ")}</div>} | ||
| </div> | ||
| </div> | ||
| ) | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
User-facing labels like 'Task Stream', 'Task Controller', and 'Task Runners' should use translation utilities rather than hardcoded strings.
This comment was generated because it violated a code review rule: irule_C0ez7Rji6ANcGkkX.