-
Notifications
You must be signed in to change notification settings - Fork 2.6k
feat(tests): core tools integration tests #4433
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
It seems that the test is failing due to a bug with the terminal execution, the command is completion is not being picked up by Roo Code and so it times out the test. This issue: #4384 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The event listener setup (e.g. messageHandler, taskStartedHandler, taskCompletedHandler) is repeated in many test files. For better maintainability, consider refactoring this repeated code into shared utility functions.
This comment was generated because it violated a code review rule: irule_tTqpIuNs8DV0QFGj.
|
This is awesome; I think we can merge this as soon as the tests pass in CI and we can continue to iterate on the mode. I can't approve the PR since I'm the author (not exactly sure how that happened). |
0ec94d3 to
46562b8
Compare
β¦sive guidelines
β¦tiple test files
β¦ improved prompts
β¦xecute_command tool
β¦iff and read_file tests
β¦cute_command tool
β¦arch_and_replace tests
f036017 to
f476e27
Compare
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disabling shell integration fixed the issue.
LGTM
* feat(tests): add apply_diff tool tests * feat(tests): add tests for write_to_file tool functionality * feat(tests): add comprehensive tests for read_file tool functionality * feat(tests): add tests for execute_command tool functionality * feat(integration-tester): add integration testing role with comprehensive guidelines * feat(tests): enhance test runner with grep and specific file filtering * feat(tests): add comprehensive tests for search_files tool functionality * feat(tests): add comprehensive tests for list_files tool functionality * feat(tests): add tests for insert_content tool functionality * feat(tests): add comprehensive tests for search_and_replace tool functionality * feat(tests): add comprehensive tests for use_mcp_tool functionality * feat(tests): increase timeout values for various tool tests to improve reliability * fix(tests): add non-null assertion for workspaceDir assignment in multiple test files * feat(tests): enhance read_file tool tests with increased timeouts and improved prompts * feat(tests): enhance read_file tool tests to extract and verify tool results * feat(tests): enhance execute_command tool tests with additional context in prompts * refactor(tests): remove script execution test and related setup for execute_command tool * fix(tests): increase timeout for task start and completion in apply_diff and read_file tests * fix(tests): clarify error handling message in command execution test * refactor(tests): remove error handling test and related setup for execute_command tool * fix: update openRouterModelId to use anthropic/claude-3.5-sonnet * fix: update openRouterModelId to use openai/gpt-4.1 * fix(tests): increase timeouts for apply_diff, execute_command, and search_and_replace tests * fix(tests): disable terminal shell integration for execute_command tool tests * chore: rewrite integration tester mode * Update .roo/rules-integration-tester/1_workflow.xml Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com> --------- Co-authored-by: Daniel Riccio <[email protected]> Co-authored-by: Daniel <[email protected]> Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Related GitHub Issue
Closes: #
Description
Test Procedure
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Documentation Updates
Additional Notes
Get in Touch
Important
Add comprehensive integration tests for Roo Code tools, including
search_and_replace,search_files,use_mcp_tool, andwrite_to_file, to validate functionality and error handling.search_and_replaceinsearch-and-replace.test.tsto validate simple text replacement, regex pattern replacement, multiple matches, and no matches scenarios.search_filesinsearch-files.test.tsto validate function definitions, TODO comments, file pattern filters, configuration keys, nested directories, complex regex patterns, and no matches scenarios.use_mcp_toolinuse-mcp-tool.test.tsto validate MCP tool requests forread_file,write_file,list_directory,directory_tree, and error handling.write_to_fileinwrite-to-file.test.tsto validate file creation with content and nested directory creation.suiteSetup,suiteTeardown,setup, andteardownhooks to manage test environments and clean up resources.waitForandsleepfromutilsfor asynchronous operations and state management.This description was created by
for 1f76576. You can customize this summary. It will automatically update as commits are pushed.