Skip to content

Fix: Reset terminal busy state after manual commands complete #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Fix: Reset terminal busy state after manual commands complete #4449

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0d70398
fix: set terminal busy flag on shell execution events (issue #4319)
Mnehmos Jun 6, 2025
54cf76a
Update TerminalRegistery.ts, closes #4319
Mnehmos Jun 8, 2025
e0e8434
terminalRegiostry.test.ts is broken outside of scope of #4319
Mnehmos Jun 8, 2025
b75c793
feat: Restore and enhance TerminalRegistry tests with busy flag coverage
Mnehmos Jun 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions src/integrations/terminal/TerminalRegistry.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ export class TerminalRegistry {

if (terminal) {
terminal.setActiveStream(stream)
terminal.busy = true // Mark terminal as busy when shell execution starts
} else {
console.error(
"[onDidStartTerminalShellExecution] Shell execution started, but not from a Roo-registered terminal:",
Expand Down Expand Up @@ -99,6 +100,7 @@ export class TerminalRegistry {
{ terminalId: terminal?.id, command: process?.command, exitCode: e.exitCode },
)

terminal.busy = false
return
}

Expand All @@ -113,6 +115,7 @@ export class TerminalRegistry {

// Signal completion to any waiting processes.
terminal.shellExecutionComplete(exitDetails)
terminal.busy = false // Mark terminal as not busy when shell execution ends
},
)

Expand Down
116 changes: 0 additions & 116 deletions src/integrations/terminal/__tests__/TerminalRegistry.test.ts
View file
Open in desktop

This file was deleted.

Loading
Loading