Skip to content

Conversation

@cte
Copy link
Collaborator

@cte cte commented Jun 9, 2025

Description

Trying to fix win32 build flakes.


Important

Fix Windows build issues by enhancing rmDir() error handling and updating error logging in esbuild.mjs.

  • Behavior:
    • In esbuild.ts, rmDir() now retries up to 5 times and handles EPERM and EACCES errors, with Windows-specific logic to clear readonly flags using execSync.
    • In esbuild.mjs, error logging in build.onEnd() now checks for location.file before logging file details.
  • Functions:
    • rmDir() in esbuild.ts now includes Windows-specific error handling and retry logic.
    • build.onEnd() in esbuild.mjs updated to conditionally log error location details.

This description was created by Ellipsis for 7b90701. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners June 9, 2025 21:45
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Jun 9, 2025
@cte cte merged commit 483d951 into main Jun 9, 2025
10 checks passed
@cte cte deleted the cte/fix-build branch June 9, 2025 22:03
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 9, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants