Skip to content

Conversation

@dtrugman
Copy link
Contributor

@dtrugman dtrugman commented Jun 9, 2025

Related GitHub Issue

Closes: #4485

Description

Control the thinking budget/effort for Gemini models via Requesty

Test Procedure

See linked issue

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Screenshots / Videos

No UI components were changed by this PR.

Documentation Updates

Does this PR necessitate updates to user-facing documentation?

  • No documentation updates are required.
  • Yes, documentation updates are required. (Please describe what needs to be updated or link to a PR in the docs repository).

Additional Notes

None


Important

Update getRequestyModels to control Gemini thinking budget by modifying reasoningBudget and reasoningEffort conditions.

  • Behavior:
    • Updates reasoningBudget in getRequestyModels to include models with IDs coding/gemini-2.5 and vertex/gemini-2.5.
    • Updates reasoningEffort in getRequestyModels to include models with ID google/gemini-2.5.

This description was created by Ellipsis for fbc9f56. You can customize this summary. It will automatically update as commits are pushed.

@dtrugman dtrugman requested review from cte, jr and mrubens as code owners June 9, 2025 23:46
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. enhancement New feature or request labels Jun 9, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 10, 2025
@cte cte merged commit e2516eb into RooCodeInc:main Jun 10, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 10, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Control Gemini thinking budget/effort via Requesty

2 participants