chore: add data-testid rule #4505
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related GitHub Issue
This was extracted from #4306
Description
I just had a realisation that our current test mode doesn't prioritise using
data-testidwhich is more reliable than relying on other attributes since it's stable.Test Procedure
Write some tests for webview-ui components using the test mode, it should now prioritise using data-testid instead of some arbitrary attributes
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Important
Adds a rule in
.roomodesto prioritizedata-testidattributes in tests for webview-ui components..roomodesto prioritizedata-testidattributes in tests for webview-ui components.data-testidattributes.This description was created by
for 4c3bba8. You can customize this summary. It will automatically update as commits are pushed.