Skip to content

Conversation

@elianiva
Copy link
Contributor

@elianiva elianiva commented Jun 10, 2025

Related GitHub Issue

This was extracted from #4306

Description

I just had a realisation that our current test mode doesn't prioritise using data-testid which is more reliable than relying on other attributes since it's stable.

Test Procedure

Write some tests for webview-ui components using the test mode, it should now prioritise using data-testid instead of some arbitrary attributes

Type of Change

  • 🐛 Bug Fix: Non-breaking change that fixes an issue.
  • New Feature: Non-breaking change that adds functionality.
  • 💥 Breaking Change: Fix or feature that would cause existing functionality to not work as expected.
  • ♻️ Refactor: Code change that neither fixes a bug nor adds a feature.
  • 💅 Style: Changes that do not affect the meaning of the code (white-space, formatting, etc.).
  • 📚 Documentation: Updates to documentation files.
  • ⚙️ Build/CI: Changes to the build process or CI configuration.
  • 🧹 Chore: Other changes that don't modify src or test files.

Pre-Submission Checklist

  • Issue Linked: This PR is linked to an approved GitHub Issue (see "Related GitHub Issue" above).
  • Scope: My changes are focused on the linked issue (one major feature/fix per PR).
  • Self-Review: I have performed a thorough self-review of my code.
  • Code Quality:
    • My code adheres to the project's style guidelines.
    • There are no new linting errors or warnings (npm run lint).
    • All debug code (e.g., console.log) has been removed.
  • Testing:
    • New and/or updated tests have been added to cover my changes.
    • All tests pass locally (npm test).
    • The application builds successfully with my changes.
  • Branch Hygiene: My branch is up-to-date (rebased) with the main branch.
  • Documentation Impact: I have considered if my changes require documentation updates (see "Documentation Updates" section below).
  • Changeset: A changeset has been created using npm run changeset if this PR includes user-facing changes or dependency updates.
  • Contribution Guidelines: I have read and agree to the Contributor Guidelines.

Important

Adds a rule in .roomodes to prioritize data-testid attributes in tests for webview-ui components.

  • Behavior:
    • Updates .roomodes to prioritize data-testid attributes in tests for webview-ui components.
  • Test Instructions:
    • Ensure tests for webview-ui components use data-testid attributes.
  • Misc:

This description was created by Ellipsis for 4c3bba8. You can customize this summary. It will automatically update as commits are pushed.

@elianiva elianiva requested review from cte, jr and mrubens as code owners June 10, 2025 17:02
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 10, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 10, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 11, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @elianiva!

LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 11, 2025
@mrubens mrubens merged commit bfeb12b into RooCodeInc:main Jun 11, 2025
18 checks passed
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 11, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm This PR has been approved by a maintainer size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants