Don't grab sidebar focus in the McpHub #4548
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
the
size:S
Member
|
Testing... |
daniel-lxs
approved these changes
Jun 11, 2025
Member
daniel-lxs
left a comment
daniel-lxs
left a comment
There was a problem hiding this comment.
I was able to confirm that this fix works by editing the mcp_settings.json file and saving it. Without the fix, saving the file would cause the sidebar to open. With the fix, changes to the file no longer open the sidebar, and I did not notice any issues with the MCP servers. The list seems to update normally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #4496 (adjusting logic added in #4267)
Can someone help me test to confirm?
Important
Simplifies
targetProviderdetermination inMcpHubto avoid sidebar focus grab by removingClineProvider.getInstance()call.targetProviderdetermination inMcpHubby removingClineProvider.getInstance()call.this.providerRef.deref()to avoid sidebar focus grab.McpHub.This description was created by
for a626b1d. You can customize this summary. It will automatically update as commits are pushed.