Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 12, 2025

Screenshot 2025-06-12 at 1 23 41 PM


Important

Move concurrent file reads setting to context settings with a default of 5 and update related UI components and tests.

  • Behavior:
    • Default maxConcurrentFileReads set to 5 in read-file.ts and ClineProvider.ts.
    • Removed concurrentFileReads from experimentIds in experiment.ts.
    • Updated system.test.ts.snap to reflect the new 5-file limit.
  • UI Components:
    • Removed ConcurrentFileReadsExperiment.tsx and its test.
    • Added maxConcurrentFileReads slider to ContextManagementSettings.tsx.
    • Updated SettingsView.tsx to handle maxConcurrentFileReads.
  • Tests:
    • Removed tests related to concurrentFileReads in experiments.test.ts.

This description was created by Ellipsis for 38995a2. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 12, 2025 17:23
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 12, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 12, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 12, 2025
@mrubens mrubens merged commit 184c480 into main Jun 12, 2025
13 checks passed
@mrubens mrubens deleted the default_to_concurrent_read branch June 12, 2025 20:21
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 12, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 12, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
* Move concurrent reads into context settings and default to 5

* Spacing tweaks

* Change max back to 100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants