Skip to content

Farewell jest #4607

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jun 17, 2025
Merged

Farewell jest #4607

merged 21 commits into from
Jun 17, 2025

Conversation

@cte
Copy link
Collaborator

@cte cte commented Jun 12, 2025 •
edited by ellipsis-dev bot
Loading

👋

Important

Replace Jest with Vitest for testing, updating configurations and test files for compatibility.

  • Testing Framework:
    • Replace Jest with Vitest for testing across the codebase.
    • Update test files to use vi for mocking and assertions.
    • Remove Jest-specific configurations and setup files.
  • Configuration:
    • Update vitest.config.ts to include necessary setup and alias configurations.
    • Remove jest.config.mjs and related Jest setup files.
  • Mocking and Imports:
    • Update imports and mocks in test files to use Vitest's vi.
    • Ensure all test files are compatible with Vitest's mocking and testing functions.
  • Logging:
    • Modify logger in logging/index.ts to use NODE_ENV for environment detection instead of Jest-specific variables.

This description was created by Ellipsis for 67bfa39. You can customize this summary. It will automatically update as commits are pushed.

@cte cte requested review from jr and mrubens as code owners June 12, 2025 20:22
@dosubot dosubot bot added the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 12, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 12, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 12, 2025
ellipsis-dev[bot]
ellipsis-dev bot reviewed Jun 12, 2025
View reviewed changes
@adamhill
Copy link
Contributor

adamhill commented Jun 12, 2025

Pouring out a 40 for my homie 🍺 💀

cte and others added 4 commits June 12, 2025 13:51
@cte
Fix tests
cf156c7
@cte
Remove spurious mocks
67bfa39
@cte @ellipsis-dev
Update .roo/rules/rules.md
0f79d0d 
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@cte @ellipsis-dev
Update src/services/tree-sitter/__tests__/helpers.ts
335ecf9 
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@cte
Copy link
Collaborator Author

cte commented Jun 12, 2025

TODO: I think the system prompt snapshot diff is problematic; seems like we're missing some mocks in src/core/prompts/__tests__/system.spec.ts.

@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jun 12, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 12, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 12, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 12, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@samhvw8
Copy link
Contributor

samhvw8 commented Jun 13, 2025

coool ! wait this to be merge <3

@cte cte mentioned this pull request Jun 13, 2025
Merged
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 17, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. labels Jun 17, 2025
@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 17, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 17, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 17, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 17, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 17, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@ellipsis-dev
Copy link
Contributor

ellipsis-dev bot commented Jun 17, 2025

⚠️ This PR is too big for Ellipsis, but support for larger PRs is coming soon. If you want us to prioritize this feature, let us know at [email protected]

Generated with ❤️ by ellipsis.dev

@cte cte merged commit 62c3914 into main Jun 17, 2025
10 checks passed
@cte cte deleted the cte/farewell-jest branch June 17, 2025 04:39
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from PR [Draft / In Progress] to Done in Roo Code Roadmap Jun 17, 2025
shivangag pushed a commit to IdenWorks/Roo-Code that referenced this pull request Jun 17, 2025
@cte @ellipsis-dev @shivangag
Farewell jest (RooCodeInc#4607)
2f33f3c 
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
@cte cte mentioned this pull request Jun 17, 2025
Merged
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
@cte @ellipsis-dev @valekseev
Farewell jest (RooCodeInc#4607)
ca18f13 
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
cte added a commit that referenced this pull request Jun 24, 2025
@cte @ellipsis-dev
Farewell jest (#4607)
013cc82 
Co-authored-by: ellipsis-dev[bot] <65095814+ellipsis-dev[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ellipsis-dev ellipsis-dev[bot] ellipsis-dev[bot] left review comments

@mrubens mrubens Awaiting requested review from mrubens mrubens is a code owner

@jr jr Awaiting requested review from jr jr is a code owner

Assignees

No one assigned

Labels

PR - Draft / In Progress size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Roo Code Roadmap
Archived in project

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cte @adamhill @samhvw8 @hannesrudolph