Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/cyan-camels-explode.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
"roo-cline": patch
---

Fix bug where language selector wasn't working
4 changes: 3 additions & 1 deletion src/core/Cline.ts
Original file line number Diff line number Diff line change
Expand Up @@ -809,7 +809,8 @@ export class Cline {
})
}

const { browserViewportSize, mode, customPrompts } = (await this.providerRef.deref()?.getState()) ?? {}
const { browserViewportSize, mode, customPrompts, preferredLanguage } =
(await this.providerRef.deref()?.getState()) ?? {}
const { customModes } = (await this.providerRef.deref()?.getState()) ?? {}
const systemPrompt = await (async () => {
const provider = this.providerRef.deref()
Expand All @@ -826,6 +827,7 @@ export class Cline {
mode,
customPrompts,
customModes,
preferredLanguage,
)
})()

Expand Down
28 changes: 28 additions & 0 deletions src/core/prompts/__tests__/sections.test.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,28 @@
import { addCustomInstructions } from "../sections/custom-instructions"

describe("addCustomInstructions", () => {
test("adds preferred language to custom instructions", async () => {
const result = await addCustomInstructions(
"mode instructions",
"global instructions",
"/test/path",
"test-mode",
{ preferredLanguage: "French" },
)

expect(result).toContain("Language Preference:")
expect(result).toContain("You should always speak and think in the French language")
})

test("works without preferred language", async () => {
const result = await addCustomInstructions(
"mode instructions",
"global instructions",
"/test/path",
"test-mode",
)

expect(result).not.toContain("Language Preference:")
expect(result).not.toContain("You should always speak and think in")
})
})
5 changes: 4 additions & 1 deletion src/core/prompts/system.ts
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ async function generatePrompt(
promptComponent?: PromptComponent,
customModeConfigs?: ModeConfig[],
globalCustomInstructions?: string,
preferredLanguage?: string,
): Promise<string> {
if (!context) {
throw new Error("Extension context is required for generating system prompt")
Expand Down Expand Up @@ -79,7 +80,7 @@ ${getSystemInfoSection(cwd, mode, customModeConfigs)}

${getObjectiveSection()}

${await addCustomInstructions(modeConfig.customInstructions || "", globalCustomInstructions || "", cwd, mode, {})}`
${await addCustomInstructions(modeConfig.customInstructions || "", globalCustomInstructions || "", cwd, mode, { preferredLanguage })}`

return basePrompt
}
Expand All @@ -95,6 +96,7 @@ export const SYSTEM_PROMPT = async (
customPrompts?: CustomPrompts,
customModes?: ModeConfig[],
globalCustomInstructions?: string,
preferredLanguage?: string,
): Promise<string> => {
if (!context) {
throw new Error("Extension context is required for generating system prompt")
Expand Down Expand Up @@ -123,5 +125,6 @@ export const SYSTEM_PROMPT = async (
promptComponent,
customModes,
globalCustomInstructions,
preferredLanguage,
)
}
Loading