Fix the save/discard/revert flow for Prompt Settings #4623
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found a bug on the Prompt page! Here's a quick fix
Normally when you edit things on the settings pages, the save button lights up, and clicking cancel will discard your changes. Currently the prompts page doesn't support this flow- the prompts are immediately saved when they change and the revert button doesn't seem to work.
With this change, we use the normal
cachedStatesystem in the SettingView, allowing users to discard changes to their prompts like any other setting. This removed the need for the resetSupportPrompt event since we send the entire state of the support prompts (same as before).Related GitHub Issue
Closes: #
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
Before, no save/discard and revert button doesn't work

After, save discard work, revert button works

Important
Adds save/discard functionality for support prompts in settings, updating state management and component behavior.
webviewMessageHandler.ts, replacing immediate save behavior.resetSupportPromptevent handling inwebviewMessageHandler.ts.PromptsSettingsto manage prompt updates and resets locally.SettingsView.tsx.ExtensionStateContext.tsxto support new prompt state management.This description was created by
for f184953. You can customize this summary. It will automatically update as commits are pushed.