Reapply reasoning for bedrock with fix #4645
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ponents - Introduced `supportsReasoningBudget` property in Bedrock models. - Enhanced `AwsBedrockHandler` to handle reasoning budget in payloads. - Updated `ThinkingBudget` component to dynamically set max tokens based on reasoning support. - Modified `ApiOptions` and `Bedrock` components to conditionally render `ThinkingBudget`. - Added tests for extended thinking functionality in `bedrock-reasoning.test.ts`.
- Simplify ThinkingBudget ternary logic since component only renders when reasoning budget supported - Break down complex thinking enabled condition with clear documentation - Replace 'as any' usage with proper TypeScript interfaces for AWS SDK events - Add comprehensive documentation for multiple stream structures explaining AWS SDK compatibility
Remove selectedProviderModels.length check to display ThinkingBudget for all providers, not just those with available models
dosubot
bot
added
the
size:XL
mrubens
approved these changes
Jun 13, 2025
github-project-automation
bot
moved this from PR [Needs Review]
to Done
in Roo Code Roadmap
cte
pushed a commit
that referenced
this pull request
Jun 24, 2025
* Add reasoning budget support to Bedrock models and update related components - Introduced `supportsReasoningBudget` property in Bedrock models. - Enhanced `AwsBedrockHandler` to handle reasoning budget in payloads. - Updated `ThinkingBudget` component to dynamically set max tokens based on reasoning support. - Modified `ApiOptions` and `Bedrock` components to conditionally render `ThinkingBudget`. - Added tests for extended thinking functionality in `bedrock-reasoning.test.ts`. * Add BedrockThinkingConfig interface and update payload structure * fix: address PR review feedback (#4481) - Simplify ThinkingBudget ternary logic since component only renders when reasoning budget supported - Break down complex thinking enabled condition with clear documentation - Replace 'as any' usage with proper TypeScript interfaces for AWS SDK events - Add comprehensive documentation for multiple stream structures explaining AWS SDK compatibility * feat: show ThinkingBudget component unconditionally Remove selectedProviderModels.length check to display ThinkingBudget for all providers, not just those with available models --------- Co-authored-by: hannesrudolph <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4201
This is the second attempt of #4481 but without removing the reasoning options for other providers, I tested it with non-reasoning and reasoning models across providers, works as expected.
Important
Reintroduces reasoning support for Bedrock models with new logic and tests, while updating UI components to reflect these changes.
supportsReasoningBudgettobedrockModelsinbedrock.ts.AwsBedrockHandlerinbedrock.ts, enabling reasoning based on settings and metadata.bedrock-reasoning.test.tsto verify reasoning behavior, including payload verification and logging.ThinkingBudget.tsxto adjust sliders for reasoning tokens based on model capabilities.Bedrock.tsxto include reasoning-related settings and options.This description was created by
for a95f254. You can customize this summary. It will automatically update as commits are pushed.