Skip to content

Conversation

@daniel-lxs
Copy link
Member

@daniel-lxs daniel-lxs commented Jun 13, 2025

This PR enhances the PR Reviewer mode by adding two new important checks to the review process:

  1. Check for Associated Issue: The workflow now includes a step to look for a linked GitHub issue in the PR body. If an issue is found, it will be fetched to provide more context for the review.
  2. Verify Scope of Changes: The reviewer will now verify that the changes in the PR are directly related to the linked issue and do not include any unrelated modifications.

These changes have been implemented across the following files:

This will help ensure that PRs are more focused and that reviewers have all the necessary context to perform a thorough review.


Important

Enhances PR Reviewer mode by adding checks for associated issues and verifying change scope in 1_workflow.xml, with updates to best practices and common mistakes.

  • Behavior:
    • Adds check for associated GitHub issue in PR body in 1_workflow.xml.
    • Verifies changes are related to the linked issue in 1_workflow.xml.
  • Best Practices:
    • Updates 2_best_practices.xml to include checking for associated issues and ensuring changes relate to the issue.
  • Common Mistakes:
    • Updates 3_common_mistakes_to_avoid.xml to avoid overlooking unrelated changes and forgetting to check for associated issues.

This description was created by Ellipsis for f3b6294. You can customize this summary. It will automatically update as commits are pushed.

@daniel-lxs daniel-lxs requested review from cte, jr and mrubens as code owners June 13, 2025 14:58
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. enhancement New feature or request labels Jun 13, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Review] in Roo Code Roadmap Jun 13, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 13, 2025
@mrubens mrubens merged commit 8718606 into main Jun 13, 2025
23 checks passed
@mrubens mrubens deleted the feat/improve_pr_reviewer branch June 13, 2025 15:08
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 13, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 13, 2025
cte pushed a commit that referenced this pull request Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants