Skip to content

Conversation

@StevenTCramer
Copy link
Contributor

@StevenTCramer StevenTCramer commented Jun 13, 2025

This pull request updates the Docker setup for the evals system to handle installation prompts for VS Code extensions automatically and changes the port mapping from 3000 to 3446 for the web service.

Changes:

  • Modified packages/evals/Dockerfile.runner to use yes | for extension installations.
  • Added DONT_PROMPT_WSL_INSTALL=1 in packages/evals/.docker/entrypoints/runner.sh to suppress WSL prompts.
  • Updated port mapping in packages/evals/docker-compose.yml to use 3446.
  • Updated documentation in packages/evals/README.md to reflect the new port.

Closes #4655


Important

Update evals Docker setup for Windows compatibility by automating VS Code extension installations and changing web service port to 3446.

  • Docker Setup:
    • Modified Dockerfile.runner to use yes | for automatic VS Code extension installations.
    • Added DONT_PROMPT_WSL_INSTALL=1 in runner.sh to suppress WSL prompts.
  • Port Mapping:
    • Changed port mapping in docker-compose.yml from 3000 to 3446.
    • Updated README.md to reflect the new port 3446 for web service access.

This description was created by Ellipsis for 77d9dcd. You can customize this summary. It will automatically update as commits are pushed.

@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 13, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Draft / In Progress] in Roo Code Roadmap Jun 13, 2025
@hannesrudolph hannesrudolph added PR - Draft / In Progress and removed Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. labels Jun 13, 2025
@hannesrudolph hannesrudolph moved this from PR [Draft / In Progress] to PR [Needs Prelim Review] in Roo Code Roadmap Jun 14, 2025
@hannesrudolph hannesrudolph marked this pull request as ready for review June 14, 2025 00:52
@hannesrudolph hannesrudolph requested review from cte, jr and mrubens as code owners June 14, 2025 00:52
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. documentation Improvements or additions to documentation enhancement New feature or request labels Jun 14, 2025
@cte
Copy link
Collaborator

cte commented Jun 14, 2025

What's the prompt that you're getting? Are there any cli options that might automatically bypass it?

@StevenTCramer
Copy link
Contributor Author

What's the prompt that you're getting? Are there any cli options that might automatically bypass it?

 To use Visual Studio Code with the Windows Subsystem for Linux, please install Visual Studio Code in Windows and uninstall the Linux version in WSL. You can then use the `code` command in a WSL terminal just as you would in a normal command prompt.
1.183 Do you want to continue anyway? [y/N]

Docker on windows uses WSL.

And I could NOT find any flag to bypass it.

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Changes Requested] in Roo Code Roadmap Jun 14, 2025
@adamhill
Copy link
Contributor

@daniel-lxs Cool. I had completely forgotten about the yes command

@StevenTCramer
Copy link
Contributor Author

@daniel-lxs Cool. I had completely forgotten about the yes command

Roo recommended it.

I found the command to be very agreeable :)

@hannesrudolph hannesrudolph moved this from PR [Changes Requested] to PR [Needs Prelim Review] in Roo Code Roadmap Jun 16, 2025
@hannesrudolph
Copy link
Collaborator

@daniel-lxs this is ready for review again

Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Just one thing to keep in mind that might be a bit confusing:

image

This is the message I saw when the evals were ready. I understand that this is showing the port inside the container though.

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 16, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 16, 2025
@cte cte merged commit fca4bea into RooCodeInc:main Jun 17, 2025
19 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 17, 2025
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:S This PR changes 10-29 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Docker Evals Setup: Installation Prompts and Port Configuration Issues

5 participants