Fixes #4647: .rooignore not working for .next folders in nested projects #4661
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #4647 The issue was that the listFiles function was using a blanket '.*' pattern to exclude all hidden directories (directories starting with a dot) at the ripgrep level, before the RooIgnoreController could process them. This meant that .next folders were being filtered out during file discovery, preventing the .rooignore patterns from working correctly for these directories. Changes: - Replaced the generic '.*' pattern in DIRS_TO_IGNORE with specific patterns for common hidden directories (.git, .svn, .hg, .bzr, .vscode, .idea) - Removed special handling for the '.*' pattern in directory filtering logic - Added test case to verify .next folders can now be properly controlled via .rooignore This allows users to specify patterns like 'example-nextjs/.next/' in their .rooignore file and have them work as expected, while still filtering out common hidden directories that should typically be ignored.
dosubot
bot
added
size:M
hannesrudolph
added
the
Issue/PR - Triage
daniel-lxs
approved these changes
Jun 13, 2025
Member
daniel-lxs
left a comment
daniel-lxs
left a comment
There was a problem hiding this comment.
Looks good, the integration test caught the change, now's a good time to remove that workaround
daniel-lxs
moved this from PR [Draft / In Progress]
to PR [Needs Review]
in Roo Code Roadmap
hannesrudolph
added
PR - Needs Review
and removed
Issue/PR - Triage
daniel-lxs
moved this from PR [Needs Review]
to PR [Needs Prelim Review]
in Roo Code Roadmap
Member
|
I'll be closing this as I think it would be better to follow the same patterns that the |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4647
Fixes issue where .rooignore patterns were not working for .next folders in nested Next.js projects.
The problem was that listFiles was using a blanket '.*' pattern to exclude all hidden directories at the ripgrep level, before RooIgnoreController could process them.
Changes:
This allows users to specify patterns like 'example-nextjs/.next/' in .rooignore and have them work correctly.
Important
Fixes
.rooignorepatterns to correctly ignore.nextfolders in nested projects by updating directory exclusion patterns and adding a test case..rooignorepatterns to correctly ignore.nextfolders in nested projects by allowing specific patterns likeexample-nextjs/.next/..*pattern with specific hidden directory patterns inlist-files.ts.RooIgnoreController.test.tsfor ignoring.nextfolders in nested projects..*pattern in directory filtering inlist-files.ts.This description was created by
for 5bf19d8. You can customize this summary. It will automatically update as commits are pushed.