Skip to content

Conversation

@chrarnoldus
Copy link
Contributor

@chrarnoldus chrarnoldus commented Jun 13, 2025

Hello Roo people! We added this on the Kilo side and thought it might be useful to you! Kilo-Org/kilocode#724

It is a port of: cline/cline#3922

Similar in scope to: #4288


Important

Adds support for extracting text from Excel (.xlsx) files using exceljs, with tests and updated dependencies.

  • Behavior:
    • Adds extractTextFromXLSX function in extract-text-from-xlsx.ts to extract text from Excel (.xlsx) files, handling various cell types and skipping hidden sheets.
    • Updates extract-text.ts to support .xlsx files by adding extractTextFromXLSX to SUPPORTED_BINARY_FORMATS.
  • Testing:
    • Adds extract-text-from-xlsx.test.ts with tests for text extraction, handling of multiple sheets, hidden sheets, and various cell value types.
  • Dependencies:
    • Adds exceljs to dependencies in package.json.

This description was created by Ellipsis for c34072a. You can customize this summary. It will automatically update as commits are pushed.

@chrarnoldus chrarnoldus requested review from cte, jr and mrubens as code owners June 13, 2025 21:10
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. enhancement New feature or request labels Jun 13, 2025
@daniel-lxs daniel-lxs moved this from Triage to PR [Needs Prelim Review] in Roo Code Roadmap Jun 13, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @chrarnoldus!

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 16, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 16, 2025
@dosubot dosubot bot added size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 17, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. size:XL This PR changes 500-999 lines, ignoring generated files. and removed size:XL This PR changes 500-999 lines, ignoring generated files. size:L This PR changes 100-499 lines, ignoring generated files. labels Jun 17, 2025
@dosubot dosubot bot removed the size:XL This PR changes 500-999 lines, ignoring generated files. label Jun 17, 2025
@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 17, 2025
@daniel-lxs daniel-lxs moved this from PR [Needs Review] to PR [Needs Prelim Review] in Roo Code Roadmap Jun 17, 2025
Copy link
Member

@daniel-lxs daniel-lxs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for removing jest from the test file!

@daniel-lxs daniel-lxs moved this from PR [Needs Prelim Review] to PR [Needs Review] in Roo Code Roadmap Jun 17, 2025
Copy link
Collaborator

@mrubens mrubens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mrubens mrubens merged commit bbbff73 into RooCodeInc:main Jun 17, 2025
16 checks passed
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from PR [Needs Review] to Done in Roo Code Roadmap Jun 17, 2025
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
@chrarnoldus chrarnoldus deleted the christiaan/excel branch July 2, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request lgtm This PR has been approved by a maintainer PR - Needs Review size:L This PR changes 100-499 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants