Skip to content

Removing manual vsix steps in favor of marketplace publishing #47

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
stea9499 merged 2 commits into from
Dec 8, 2024
Merged

Removing manual vsix steps in favor of marketplace publishing #47

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3611c35
Removing manual vsix steps in favor of marketplace publishing
stea9499 Dec 7, 2024
a707a47
Add back vsix build target for manual testing and add roo-cline*vsix …
stea9499 Dec 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion .github/workflows/marketplace-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,5 @@ jobs:
VSCE_PAT: ${{ secrets.VSCE_PAT }}
run: |
current_package_version=$(node -p "require('./package.json').version")
npm run vsix
npm run publish:marketplace
echo "Successfully published version $current_package_version to VS Code Marketplace"
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,4 +5,6 @@ node_modules

.DS_Store

.npmrc
.npmrc

roo-cline-*.vsix
Binary file removed bin/roo-cline-2.1.11.vsix
View file
Open in desktop
Binary file not shown.
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,7 @@
},
"scripts": {
"vscode:prepublish": "npm run package",
"vsix": "vsce package --out bin",
Copy link
Collaborator

@mrubens mrubens Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fwiw I don't think it hurts to leave this in case we want to build it manually for testing before pushing to the marketplace. Maybe we could just add a bin/.empty file to make sure the directory exists?

Copy link
Contributor Author

@stea9499 stea9499 Dec 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok added back the build target, but removed the bin dependency and added roo-cline-.vsix to .gitignore

"vsix": "vsce package",
"compile": "npm run check-types && npm run lint && node esbuild.js",
"watch": "npm-run-all -p watch:*",
"watch:esbuild": "node esbuild.js --watch",
Expand Down
Loading