Skip to content

Conversation

@SmartManoj
Copy link
Contributor

@SmartManoj SmartManoj commented Jun 15, 2025

Workaround for #4697 (comment)

Before:

image

(hallucinates)

After:

image


Important

Removes supportsComputerUse check in getBrowserActionDescription() to allow all models to use browser actions.

  • Behavior:
    • Removes supportsComputerUse check in getBrowserActionDescription() in browser-action.ts, allowing all models to use browser actions.
  • Misc:

This description was created by Ellipsis for 832e731. You can customize this summary. It will automatically update as commits are pushed.

@SmartManoj SmartManoj requested review from cte, jr and mrubens as code owners June 15, 2025 06:08
@dosubot dosubot bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 15, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 15, 2025
@daniel-lxs
Copy link
Member

This PR bypasses the browser tool security settings.

By removing the supportsComputerUse check, the browser tool description will be shown to ALL models, even when:

  • The model doesn't support computer use
  • The user has disabled browser tools (browserToolEnabled: false)

This defeats the purpose of the three-layer security model (model support + mode configuration + user setting) and will cause models to hallucinate browser actions they cannot execute.

The existing implementation correctly enforces that only models with supportsComputerUse: true AND user permission (browserToolEnabled) can access browser tools.

@daniel-lxs daniel-lxs closed this Jun 16, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 16, 2025
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 16, 2025
@SmartManoj
Copy link
Contributor Author

#4720

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

3 participants