Fixes #4746: Prevent PowerShell commands from hanging indefinitely #4757
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes issue #4746 where RooCode would wait indefinitely for user input after executing PowerShell commands instead of automatically resuming when the command completes.
Root Cause
The issue was caused by PowerShell commands with sleep delays not properly signaling completion to VSCode's shell integration. When the PowerShell counter workaround and command delay features were enabled, the additional commands appended to the original command could cause the shell integration to not properly detect when the command had finished executing.
Changes Made
Technical Details
Testing
Fixes
Closes #4746
Important
Fixes indefinite hanging of PowerShell commands in
TerminalProcess.tsby adding timeouts and ensuring proper command completion.try-finallyblocks inTerminalProcess.tsto ensure proper completion.Write-Outputfor PowerShell counter workaround.try-finally.This description was created by
for 8b42c16. You can customize this summary. It will automatically update as commits are pushed.