Fixes #4745: Improve AWS Bedrock throttling error handling and retry mechanism #4760
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mechanism - Enhanced error pattern matching to include 'unable to process your request', 'too many tokens', 'please wait', and 'service is temporarily unavailable' - Added HTTP status code 429 and AWS ThrottlingException detection - Modified streaming error handler to re-throw throttling errors for retry mechanism - Updated completePrompt error handler for consistent throttling error treatment - Added comprehensive test suite for error handling improvements This ensures throttling errors are properly identified and trigger automatic retry with exponential backoff instead of showing generic 'Unknown Error' messages.
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
hannesrudolph
added
PR - Needs Preliminary Review
and removed
Issue/PR - Triage
Member
|
Closing in favor of #4748 |
github-project-automation
bot
moved this from PR [Needs Prelim Review]
to Done
in Roo Code Roadmap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures throttling errors are properly identified and trigger automatic retry with exponential backoff instead of showing generic 'Unknown Error' messages.
Important
Improves AWS Bedrock throttling error handling by enhancing detection and ensuring retries, with comprehensive tests added.
getErrorType()inbedrock.tsto detect throttling errors by HTTP status code 429, AWS metadata, and specific error messages.createMessage()andcompletePrompt()inbedrock.tsto re-throw throttling errors for retry handling.handleBedrockError()inbedrock.tsto format throttling error messages with guidance.bedrock-error-handling.spec.tsto test enhanced error detection and handling, including various throttling scenarios.This description was created by
for 6ddeb73. You can customize this summary. It will automatically update as commits are pushed.