Fixes #4732: Enforce mode file restrictions immediately when path is provided #4765
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…provided - Fixed bug in isToolAllowedForMode where file regex validation was only triggered when content/diff/operations were present - Mode permissions are now enforced as soon as a file path is provided, preventing bypass during streaming/partial tool calls - Updated tests to reflect correct behavior and added reproduction test - This prevents modes like Architect from editing restricted files like PowerShell scripts when they should only edit markdown/config files
dosubot
bot
added
size:L
hannesrudolph
added
the
Issue/PR - Triage
Member
|
Closing temporarily, see #4732 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
triggered when content/diff/operations were present
preventing bypass during streaming/partial tool calls
PowerShell scripts when they should only edit markdown/config files
Important
Fixes bug in
isToolAllowedForModeto enforce file restrictions immediately when a file path is provided, preventing unauthorized file edits in specific modes.isToolAllowedForModeinmodes.tsto enforce file restrictions immediately when a file path is provided.modes.test.tsto reflect correct behavior and added tests to reproduce issue Roo Code ignores mode permissions if concurrent file edits are enabled #4732.This description was created by
for 33e0004. You can customize this summary. It will automatically update as commits are pushed.