Skip to content

Conversation

@mrubens
Copy link
Collaborator

@mrubens mrubens commented Jun 17, 2025

Important

Improves MDM compliance handling by updating checks, environment variable usage, and UI behavior across multiple files.

  • Behavior:
    • MDM compliance check moved in ClineProvider.ts to post-message to webview if non-compliant.
    • App.tsx prevents tab switching if mdmCompliant is false, except to "account" tab.
  • Config:
    • Introduces PRODUCTION_CLERK_BASE_URL and PRODUCTION_ROO_CODE_API_URL constants in Config.ts.
    • Updates getClerkBaseUrl and getRooCodeApiUrl to use these constants as fallbacks.
  • MDM Service:
    • MdmService.ts uses getClerkBaseUrl to determine production environment.
    • Adjusts compliance check logic to use getClerkBaseUrl instead of NODE_ENV.
  • Tests:
    • Updates MdmService.spec.ts to mock getClerkBaseUrl and test new compliance logic.
    • Adds tests for platform-specific config paths using getClerkBaseUrl.
  • UI:
    • ExtensionStateContext.tsx and App.tsx updated to handle mdmCompliant state.

This description was created by Ellipsis for 38fb1e0. You can customize this summary. It will automatically update as commits are pushed.

@mrubens mrubens requested review from cte and jr as code owners June 17, 2025 03:26
@dosubot dosubot bot added the size:M This PR changes 30-99 lines, ignoring generated files. label Jun 17, 2025
@hannesrudolph hannesrudolph added the Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. label Jun 17, 2025
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 17, 2025
@mrubens mrubens merged commit e95c1e8 into main Jun 17, 2025
12 of 13 checks passed
@mrubens mrubens deleted the mdm_fixes branch June 17, 2025 11:35
@github-project-automation github-project-automation bot moved this from New to Done in Roo Code Roadmap Jun 17, 2025
@github-project-automation github-project-automation bot moved this from Triage to Done in Roo Code Roadmap Jun 17, 2025
valekseev pushed a commit to valekseev/Roo-Code that referenced this pull request Jun 18, 2025
* Better check for production clerk

* Send to account tab if required

* Fix tests
cte pushed a commit that referenced this pull request Jun 24, 2025
* Better check for production clerk

* Send to account tab if required

* Fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Issue/PR - Triage New issue. Needs quick review to confirm validity and assign labels. lgtm This PR has been approved by a maintainer size:M This PR changes 30-99 lines, ignoring generated files.

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

4 participants