Skip to content

Conversation

@monotykamary
Copy link
Contributor

@monotykamary monotykamary commented Jan 22, 2025

Description

Fixes an issue where configs were being deleted even when the config name was not changed. This change ensures that configs are only deleted when their names are actually modified.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Manually tested by building the extension and editing the config without making any changes to the config name. Verified that configs are not deleted in this scenario.

Checklist:

  • My code follows the patterns of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Additional context

This fix addresses a bug introduced in a previous change that incorrectly deleted configs even when no changes were made to their names.

Related Issues

Reviewers


Important

Fixes bug in ApiConfigManager.tsx to prevent config deletion when currentApiConfigName is unchanged.

  • Behavior:
    • Fixes bug in ApiConfigManager.tsx where configs were deleted even if currentApiConfigName was unchanged.
    • onRenameConfig is now only called if currentApiConfigName differs from trimmedValue.

This description was created by Ellipsis for 8ad904a. It will automatically update as commits are pushed.

@changeset-bot
Copy link

changeset-bot bot commented Jan 22, 2025

⚠️ No Changeset found

Latest commit: 8ad904a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@monotykamary monotykamary changed the title fix: avoid deleting configs if the currentApiConfigName hasn't been c… fix: avoid deleting configs if the currentApiConfigName is the same Jan 22, 2025
@mrubens mrubens merged commit 21c7ac7 into RooCodeInc:main Jan 22, 2025
6 checks passed
@mrubens mrubens mentioned this pull request Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants