-
Notifications
You must be signed in to change notification settings - Fork 2.6k
Close the local browser when used as fallback for remote #4823
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Close the local browser when used as fallback for remote #4823
Conversation
162ae55 to
fd8cec8
Compare
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @markijbema, thank you for contributing to fix the issue.
I left a couple of suggestions that might be worth taking a look at, let me know what you think!
When we configure Roo to use the remote browser, but none is available, it falls back to a local browser. Administrate this in isUsingRemoteBrowser and use this to determine to close which browser when closing the browser.
fd8cec8 to
112b38c
Compare
daniel-lxs
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thank you @markijbema!
When we configure kilo to use the remote browser, but none is available, it falls back to a local browser. Administrate this in isUsingRemoteBrowser and use this to determine to close which browser when closing the browser.
Related GitHub Issue
Closes: #4822
Description
Instead of looking at what browser should have been used, look at what browser is actually used and close that
Test Procedure
Enable remote browser connection (checkbox)
(but do not actually start one)
Open the activity monitor (on macosx, or the equivalent on your OS)
Ask a simple browser request, for instance "give me the most important headline from cnn.com"
You can see chrome helpers starting
And when Roo says it closes the browser you can see them stopping/disappearing
Type of Change
srcor test files.Pre-Submission Checklist
npm run lint).console.log) has been removed.npm test).mainbranch.npm run changesetif this PR includes user-facing changes or dependency updates.Screenshots / Videos
N/A
Documentation Updates
Additional Notes
Get in Touch
Important
Fixes browser closing logic in
BrowserSessionby tracking actual browser usage withisUsingRemoteBrowser.isUsingRemoteBrowserinBrowserSessionto track if a remote browser is used.closeBrowser()to useisUsingRemoteBrowserto determine whether to disconnect or close the browser.launchLocalBrowser()andconnectWithChromeHostUrl()to setisUsingRemoteBrowserappropriately.This description was created by
for fd8cec8b4c786e7d2aabf043f36fafa05e82ad47. You can customize this summary. It will automatically update as commits are pushed.